[systemd-commits] 2 commits - TODO src/core src/shared

Lennart Poettering lennart at kemper.freedesktop.org
Wed Dec 10 11:03:32 PST 2014


 TODO                 |    3 +--
 src/core/dbus-unit.c |    2 +-
 src/shared/install.c |    1 -
 3 files changed, 2 insertions(+), 4 deletions(-)

New commits:
commit d0928791499734e202460d5c027b5d3e0d28e7ab
Author: Lennart Poettering <lennart at poettering.net>
Date:   Wed Dec 10 19:57:52 2014 +0100

    update TODO

diff --git a/TODO b/TODO
index 7d7f90a..124f7d9 100644
--- a/TODO
+++ b/TODO
@@ -4,8 +4,6 @@ Preparations for 218:
 
 * test-bus-kernel-bloom is borked
 
-* systemctl status reports all services as runtime-enabled?
-
 Bugfixes:
 
 * Should systemctl status \* work on all unit types, not just .service?
@@ -308,6 +306,7 @@ Features:
   ReadOnlyDirectories=... for whitelisting files for a service.
 
 * sd-bus:
+  - kdbus: process fd=-1 for incoming msgs
   - make dsrt happy, and change userspace header for kdbus to yyyyuta{tv}v
   - kdbus: remove NameOwnerChanged kernel messages for monitors
   - kdbus: PID/TID goes missing for method calls from outside the PID namespace?

commit 764458325ef3586229137694538bcf5e8bde8c48
Author: Lennart Poettering <lennart at poettering.net>
Date:   Wed Dec 10 19:57:45 2014 +0100

    core: properly pass unit file state to clients via the bus

diff --git a/src/core/dbus-unit.c b/src/core/dbus-unit.c
index 0850fb3..b968009 100644
--- a/src/core/dbus-unit.c
+++ b/src/core/dbus-unit.c
@@ -207,7 +207,7 @@ static int property_get_unit_file_state(
         assert(reply);
         assert(u);
 
-        return sd_bus_message_append(reply, "s", unit_file_state_to_string(unit_get_unit_file_preset(u)));
+        return sd_bus_message_append(reply, "s", unit_file_state_to_string(unit_get_unit_file_state(u)));
 }
 
 static int property_get_can_start(
diff --git a/src/shared/install.c b/src/shared/install.c
index 5bb3385..efbe61e 100644
--- a/src/shared/install.c
+++ b/src/shared/install.c
@@ -538,7 +538,6 @@ static int find_symlinks_in_scope(
         assert(scope < _UNIT_FILE_SCOPE_MAX);
         assert(name);
 
-
         /* First look in runtime config path */
         r = get_config_path(scope, true, root_dir, &path);
         if (r < 0)



More information about the systemd-commits mailing list