[systemd-commits] 2 commits - TODO src/systemctl

Lennart Poettering lennart at kemper.freedesktop.org
Mon Jan 20 04:44:20 PST 2014


 TODO                      |    6 ++++++
 src/systemctl/systemctl.c |    5 +++++
 2 files changed, 11 insertions(+)

New commits:
commit 67d6621059085963a2a908a3ea99ced3b0ca789e
Author: Lennart Poettering <lennart at poettering.net>
Date:   Mon Jan 20 13:43:20 2014 +0100

    systemctl: skip native unit file handling if sysv file handling already handled everything
    
    Issue pointed out by Colin Guthrie.

diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c
index b9d9b3a..d850b8b 100644
--- a/src/systemctl/systemctl.c
+++ b/src/systemctl/systemctl.c
@@ -4740,6 +4740,11 @@ static int enable_unit(sd_bus *bus, char **args) {
         if (r < 0)
                 return r;
 
+        /* If the operation was fully executed by the SysV compat,
+         * let's finish early */
+        if (strv_isempty(names))
+                return 0;
+
         if (!bus || avoid_bus()) {
                 if (streq(verb, "enable")) {
                         r = unit_file_enable(arg_scope, arg_runtime, arg_root, names, arg_force, &changes, &n_changes);

commit 488ad3b32a7e2b5b1380abf4a15e5f65fa65f3fe
Author: Lennart Poettering <lennart at poettering.net>
Date:   Mon Jan 20 13:42:52 2014 +0100

    update TODO

diff --git a/TODO b/TODO
index a842158..1e0f334 100644
--- a/TODO
+++ b/TODO
@@ -32,6 +32,12 @@ External:
 
 Features:
 
+* socket units: support creating sockets in different namespace,
+  opening it up for JoinsNamespaceOf=. This would require to fork off
+  a tiny process that joins the namespace and creates/binds the socket
+  and passes this back to PID1 via SCM_RIGHTS. This also could be used
+  to allow Chown/chgrp on sockets without requiring NSS in PID 1.
+
 * sd-resolve:
   - make sure event loop integration works similar to event loop integration in other libs
   - maybe drop _free() call, introduce _unref() instead



More information about the systemd-commits mailing list