[systemd-commits] 2 commits - TODO src/resolve

[Lennart Poettering]

 TODO                              |    7 +++++++
 src/resolve/resolved-dns-server.c |    2 +-
 src/resolve/resolved-dns-server.h |   11 ++++++-----
 3 files changed, 14 insertions(+), 6 deletions(-)

New commits:
commit 7f035ea56bc0b75327c54e8aa4a56d57ed00dd6d
Author: Lennart Poettering <lennart at poettering.net>
Date:   Fri Jul 18 13:59:55 2014 +0200

    update TODO

diff --git a/TODO b/TODO
index 8bacee7..bfa06de 100644
--- a/TODO
+++ b/TODO
@@ -24,6 +24,13 @@ External:
 
 Features:
 
+* libsystemd-network:
+  - I don't think there should be a client side object for dhcp
+    releases (probably not even a directory in /run for it)
+  - the order between ipv6 and ipv4 dns servers probably matters,
+    hence the current DNS apis won't suffice
+  - sd_network_get_ifindices() sounds redundant, rtnetlink can do that too
+
 * resolved:
   - IDN (?)
   - DNSSEC

commit 3c0cf502796be355431d4a64d738e75f543aa51d
Author: Lennart Poettering <lennart at poettering.net>
Date:   Fri Jul 18 13:59:49 2014 +0200

    resolved: add more const

diff --git a/src/resolve/resolved-dns-server.c b/src/resolve/resolved-dns-server.c
index 4e0220b..07754a0 100644
--- a/src/resolve/resolved-dns-server.c
+++ b/src/resolve/resolved-dns-server.c
@@ -27,7 +27,7 @@ int dns_server_new(
                 DnsServerSource source,
                 Link *l,
                 unsigned char family,
-                union in_addr_union *in_addr) {
+                const union in_addr_union *in_addr) {
 
         DnsServer *s, *tail;
 
diff --git a/src/resolve/resolved-dns-server.h b/src/resolve/resolved-dns-server.h
index adceb86..781e237 100644
--- a/src/resolve/resolved-dns-server.h
+++ b/src/resolve/resolved-dns-server.h
@@ -21,10 +21,11 @@
   along with systemd; If not, see <http://www.gnu.org/licenses/>.
 ***/
 
+#include "in-addr-util.h"
+
 typedef struct DnsServer DnsServer;
 typedef enum DnsServerSource DnsServerSource;
 
-#include "in-addr-util.h"
 #include "resolved.h"
 #include "resolved-link.h"
 #include "resolved-dns-server.h"
@@ -40,12 +41,12 @@ struct DnsServer {
         Manager *manager;
         DnsServerSource source;
 
+        Link *link;
+
         unsigned char family;
         union in_addr_union address;
 
-        bool marked;
-
-        Link *link;
+        bool marked:1;
 
         LIST_FIELDS(DnsServer, servers);
 };
@@ -56,6 +57,6 @@ int dns_server_new(
                 DnsServerSource source,
                 Link *l,
                 unsigned char family,
-                union in_addr_union *in_addr);
+                const union in_addr_union *address);
 
 DnsServer* dns_server_free(DnsServer *s);