[systemd-commits] src/network

Zbigniew Jędrzejewski-Szmek zbyszek at kemper.freedesktop.org
Sat Mar 8 09:21:05 PST 2014


 src/network/networkd-link.c |    8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

New commits:
commit 58b129170ca6acacffd853b6c8fbec9fce2c2163
Author: Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl>
Date:   Sat Mar 8 11:57:28 2014 -0500

    networkd: fix confusion from missing braces
    
    Fixup for 76800848f281c3 'networkd: link - degrade failed UP to warning'.

diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c
index 9fb8d9f..a97e347 100644
--- a/src/network/networkd-link.c
+++ b/src/network/networkd-link.c
@@ -1056,16 +1056,14 @@ static int link_up_handler(sd_rtnl *rtnl, sd_rtnl_message *m, void *userdata) {
                 return 1;
 
         r = sd_rtnl_message_get_errno(m);
-        if (r < 0)
+        if (r >= 0)
+                link_update_flags(link, link->flags | IFF_UP);
+        else
                 log_struct_link(LOG_WARNING, link,
                                 "MESSAGE=%s: could not bring up interface: %s",
                                 link->ifname, strerror(-r),
                                 "ERRNO=%d", -r,
                                 NULL);
-                return 1;
-
-        link_update_flags(link, link->flags | IFF_UP);
-
         return 1;
 }
 



More information about the systemd-commits mailing list