[systemd-commits] 2 commits - TODO src/core

[Lennart Poettering]

 TODO               |    2 ++
 src/core/manager.c |   14 ++++++--------
 2 files changed, 8 insertions(+), 8 deletions(-)

New commits:
commit 498e87d6b7ef025fef2e089931f355b5cd3c7dad
Author: Lennart Poettering <lennart at poettering.net>
Date:   Fri Nov 7 02:05:50 2014 +0100

    manager: cast mkdir() result to (void) to make sure coverity is quiet
    
    Also simplify the code a bit by moving mkdir to the common path.

diff --git a/src/core/manager.c b/src/core/manager.c
index 129f6dd..e596494 100644
--- a/src/core/manager.c
+++ b/src/core/manager.c
@@ -662,11 +662,9 @@ static int manager_setup_notify(Manager *m) {
                         return -errno;
                 }
 
-                if (m->running_as == SYSTEMD_SYSTEM) {
+                if (m->running_as == SYSTEMD_SYSTEM)
                         m->notify_socket = strdup("/run/systemd/notify");
-                        if (!m->notify_socket)
-                                return log_oom();
-                } else {
+                else {
                         const char *e;
 
                         e = getenv("XDG_RUNTIME_DIR");
@@ -676,11 +674,11 @@ static int manager_setup_notify(Manager *m) {
                         }
 
                         m->notify_socket = strappend(e, "/systemd/notify");
-                        if (!m->notify_socket)
-                                return log_oom();
-
-                        mkdir_parents_label(m->notify_socket, 0755);
                 }
+                if (!m->notify_socket)
+                        return log_oom();
+
+                (void) mkdir_parents_label(m->notify_socket, 0755);
 
                 strncpy(sa.un.sun_path, m->notify_socket, sizeof(sa.un.sun_path)-1);
                 r = bind(fd, &sa.sa, offsetof(struct sockaddr_un, sun_path) + strlen(sa.un.sun_path));

commit 4e143738bf170be9f957c47605deea8c54b75fdf
Author: Lennart Poettering <lennart at poettering.net>
Date:   Fri Nov 7 02:01:47 2014 +0100

    update TODO

diff --git a/TODO b/TODO
index f26aae8..5353340 100644
--- a/TODO
+++ b/TODO
@@ -37,6 +37,8 @@ External:
 
 Features:
 
+* kdbus: set the bus-wide creds sender requirement mask to ANY
+
 * code cleanup: retire FOREACH_WORD_QUOTED, port to unquote_first_word() loops instead
 
 * logind: when the power button is pressed short, just popup a logout dialog. If it is pressed for 1s, do the usual shutdown. Inspiration are Macs here.