[systemd-commits] src/core

[David Herrmann]

 src/core/smack-setup.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit b9289d4c6e13ec5fb67bfce69c826d93b004da6a
Author: Philippe De Swert <philippedeswert at gmail.com>
Date:   Fri Sep 12 16:49:48 2014 +0300

    core: smack-setup: Actually allow for succesfully loading CIPSO policy
    
    The line under the last switch statement  *loaded_policy = true;
    would never be executed. As all switch cases return 0. Thus the
    policy would never be marked as loaded.
    
    Found with Coverity. Fixes: CID#1237785

diff --git a/src/core/smack-setup.c b/src/core/smack-setup.c
index 5f6dabf..5d8a26c 100644
--- a/src/core/smack-setup.c
+++ b/src/core/smack-setup.c
@@ -158,7 +158,7 @@ int smack_setup(bool *loaded_policy) {
                 return 0;
         case 0:
                 log_info("Successfully loaded Smack/CIPSO policies.");
-                return 0;
+                break;
         default:
                 log_warning("Failed to load Smack/CIPSO access rules: %s, ignoring.",
                             strerror(abs(r)));