[systemd-commits] src/systemctl
Daniel Mack
zonque at kemper.freedesktop.org
Thu Sep 18 01:18:53 PDT 2014
src/systemctl/systemctl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 48a2900c6612052149a1d0dd88aeacb99b49ce4d
Author: Cristian RodrÃguez <crrodriguez at opensuse.org>
Date: Wed Sep 17 21:56:25 2014 -0300
systemctl: fix resource leak CID #1237747
..by simply moving the declaration of "unit" into the STRV_FOREACH
loop as suggested by Andreas.
diff --git a/src/systemctl/systemctl.c b/src/systemctl/systemctl.c
index 88be871..9012128 100644
--- a/src/systemctl/systemctl.c
+++ b/src/systemctl/systemctl.c
@@ -4449,7 +4449,6 @@ static int show(sd_bus *bus, char **args) {
}
static int cat(sd_bus *bus, char **args) {
- _cleanup_free_ char *unit = NULL;
_cleanup_strv_free_ char **names = NULL;
char **name;
bool first = true;
@@ -4468,6 +4467,8 @@ static int cat(sd_bus *bus, char **args) {
_cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL;
_cleanup_strv_free_ char **dropin_paths = NULL;
_cleanup_free_ char *fragment_path = NULL;
+ _cleanup_free_ char *unit = NULL;
+
char **path;
unit = unit_dbus_path_from_name(*name);
More information about the systemd-commits
mailing list