[systemd-commits] 2 commits - man/systemd.unit.xml src/journal

David Herrmann dvdhrm at kemper.freedesktop.org
Thu Sep 18 06:41:14 PDT 2014


 man/systemd.unit.xml         |    2 +-
 src/journal/journal-verify.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit e8c108ca9f11a382742f212f5b42a02536b3d40f
Author: Philippe De Swert <philippedeswert at gmail.com>
Date:   Wed Sep 17 00:27:16 2014 +0300

    journal: Do not count on the compiler initializing found_last to false
    
    There is a very unlikely case where this can happen since gcc usually
    does the sane thing. But let's make sure found_last is initialized anyway.
    
    Fixes: CID#996386

diff --git a/src/journal/journal-verify.c b/src/journal/journal-verify.c
index 6c8ca8c..b4e8f73 100644
--- a/src/journal/journal-verify.c
+++ b/src/journal/journal-verify.c
@@ -804,7 +804,7 @@ int journal_file_verify(
         usec_t last_usec = 0;
         int data_fd = -1, entry_fd = -1, entry_array_fd = -1;
         unsigned i;
-        bool found_last;
+        bool found_last = false;
 #ifdef HAVE_GCRYPT
         uint64_t last_tag = 0;
 #endif

commit fb7661a6020b5680d5647d3d85b0501a4f3a5042
Author: Michael Marineau <michael.marineau at coreos.com>
Date:   Mon Sep 15 14:07:39 2014 -0700

    man: use the escape for "-" in example instead of space.
    
    This sentence can be misread to mean that "\x20" is the escape code for
    "-" which is the only character explicitly mentioned. This lead to at
    least one user loosing hair over why a mount unit for "/foo/bar-baz"
    didn't work. The example escape is arbitrary so lets prevent hair loss.

diff --git a/man/systemd.unit.xml b/man/systemd.unit.xml
index 6ea552e..67d46ed 100644
--- a/man/systemd.unit.xml
+++ b/man/systemd.unit.xml
@@ -226,7 +226,7 @@
                 result is usable as part of a filename. Basically,
                 given a path, "/" is replaced by "-", and all
                 unprintable characters and the "-" are replaced by
-                C-style "\x20" escapes. The root directory "/" is
+                C-style "\x2d" escapes. The root directory "/" is
                 encoded as single dash, while otherwise the initial
                 and ending "/" is removed from all paths during
                 transformation. This escaping is reversible.</para>



More information about the systemd-commits mailing list