[systemd-commits] src/bootchart

Thomas H.P. Andersen phomes at kemper.freedesktop.org
Sun Sep 28 10:35:41 PDT 2014


 src/bootchart/store.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c119700c06b248b1c2a082b40b1a346f58d89da0
Author: Philippe De Swert <philippe.deswert at jollamobile.com>
Date:   Sun Sep 28 18:12:51 2014 +0300

    bootchart: Do not try to access data for non-existing CPU's
    
    Cpu's are assigned normally, so starting at 0, so the MAX_CPU index will
    always be one smaller than the actual number.
    
    Found with Coverity.

diff --git a/src/bootchart/store.c b/src/bootchart/store.c
index 3099ff1..9ea1b27 100644
--- a/src/bootchart/store.c
+++ b/src/bootchart/store.c
@@ -199,7 +199,7 @@ vmstat_next:
 
                 if (strstr(key, "cpu")) {
                         r = safe_atoi((const char*)(key+3), &c);
-                        if (r < 0 || c > MAXCPUS)
+                        if (r < 0 || c > MAXCPUS -1)
                                 /* Oops, we only have room for MAXCPUS data */
                                 break;
                         sampledata->runtime[c] = atoll(rt);



More information about the systemd-commits mailing list