[systemd-commits] 5 commits - CODING_STYLE TODO units/basic.target units/systemd-udev-trigger.service.in units/systemd-udevd.service.in units/systemd-user-sessions.service.in

[Lennart Poettering]

 CODING_STYLE                           |    7 +++++++
 TODO                                   |    7 +++++++
 units/basic.target                     |    8 +++++---
 units/systemd-udev-trigger.service.in  |    2 +-
 units/systemd-udevd.service.in         |    2 +-
 units/systemd-user-sessions.service.in |    2 +-
 6 files changed, 22 insertions(+), 6 deletions(-)

New commits:
commit 61192f1d6954196d5066942241a024de4712243c
Author: Lennart Poettering <lennart at poettering.net>
Date:   Fri Apr 3 14:34:59 2015 +0200

    update TODO

diff --git a/TODO b/TODO
index abc3dee..40d7d78 100644
--- a/TODO
+++ b/TODO
@@ -42,8 +42,15 @@ Before 220:
 
 * bus-proxy: GetConnectionSELinuxSecurityContext() is completely broken
 
+* logind: make sure the syncrhonous polkit checks are not interactive, i.e. supporess client side interactive bus message header flag for them
+
+* timer units triggering services with failing conditions run busy:
+  http://lists.freedesktop.org/archives/systemd-devel/2015-April/030095.html
+
 Features:
 
+* the default stop timeout for units is not documented anywhere.
+
 * .timer units should optionally support CLOCK_BOOTTIME in addition to CLOCK_MONOTONIC
 
 * rm_rf() should be able to remove subvolumes

commit 49d7fc99b939aa9e6601abb2d871f3ef78dc90f5
Author: Lennart Poettering <lennart at poettering.net>
Date:   Fri Apr 3 14:32:32 2015 +0200

    units: explicitly require /var, /tmp and /var/tmp to be mounted before basic.target
    
    We support /var, /tmp and /var/tmp on NFS. NFS shares however are by
    default ordered only before remote-fs.target which is a late-boot
    service. /var, /tmp, /var/tmp need to be around earlier though, hence
    explicitly order them before basic.target.
    
    Note that this change simply makes explicit what was implicit before,
    since many early-boot services pulled in parts of /var anyway early.

diff --git a/units/basic.target b/units/basic.target
index abb63ec..e0e1e60 100644
--- a/units/basic.target
+++ b/units/basic.target
@@ -8,8 +8,10 @@
 [Unit]
 Description=Basic System
 Documentation=man:systemd.special(7)
-
 Requires=sysinit.target
-After=sysinit.target
 Wants=sockets.target timers.target paths.target slices.target
-After=sockets.target paths.target slices.target
+After=sysinit.target sockets.target paths.target slices.target
+
+# We support /var, /tmp, /var/tmp, being on NFS, but we don't pull in
+# remote-fs.target by default, hence explicitly pull /var in here.
+RequiresMountsFor=/var /tmp /var/tmp

commit efb3e19be9c568974b221990b9e84fb5304c5537
Author: Lennart Poettering <lennart at poettering.net>
Date:   Fri Apr 3 14:31:35 2015 +0200

    units: explicitly order systemd-user-sessions.service after nss-user-lookup.target
    
    We should not allow logins before NIS/LDAP users are available.

diff --git a/units/systemd-user-sessions.service.in b/units/systemd-user-sessions.service.in
index 0869e73..c09c05d 100644
--- a/units/systemd-user-sessions.service.in
+++ b/units/systemd-user-sessions.service.in
@@ -8,7 +8,7 @@
 [Unit]
 Description=Permit User Sessions
 Documentation=man:systemd-user-sessions.service(8)
-After=remote-fs.target
+After=remote-fs.target nss-user-lookup.target
 
 [Service]
 Type=oneshot

commit d8f0930eec248c2f54c85aa5029e1b3775c8dc75
Author: Lennart Poettering <lennart at poettering.net>
Date:   Fri Apr 3 14:27:16 2015 +0200

    units: move After=systemd-hwdb-update.service dependency from udev to udev-trigger
    
    Let's move the hwdb regeneration a bit later. Given that hwdb is
    non-essential it should be OK to allow udev to run without it until we
    do the full trigger.
    
    http://lists.freedesktop.org/archives/systemd-devel/2015-April/030074.html

diff --git a/units/systemd-udev-trigger.service.in b/units/systemd-udev-trigger.service.in
index 0c33909..1e04d11 100644
--- a/units/systemd-udev-trigger.service.in
+++ b/units/systemd-udev-trigger.service.in
@@ -10,7 +10,7 @@ Description=udev Coldplug all Devices
 Documentation=man:udev(7) man:systemd-udevd.service(8)
 DefaultDependencies=no
 Wants=systemd-udevd.service
-After=systemd-udevd-kernel.socket systemd-udevd-control.socket
+After=systemd-udevd-kernel.socket systemd-udevd-control.socket systemd-hwdb-update.service
 Before=sysinit.target
 ConditionPathIsReadWrite=/sys
 
diff --git a/units/systemd-udevd.service.in b/units/systemd-udevd.service.in
index 2791f73..a133044 100644
--- a/units/systemd-udevd.service.in
+++ b/units/systemd-udevd.service.in
@@ -10,7 +10,7 @@ Description=udev Kernel Device Manager
 Documentation=man:systemd-udevd.service(8) man:udev(7)
 DefaultDependencies=no
 Wants=systemd-udevd-control.socket systemd-udevd-kernel.socket
-After=systemd-udevd-control.socket systemd-udevd-kernel.socket systemd-hwdb-update.service systemd-sysusers.service
+After=systemd-udevd-control.socket systemd-udevd-kernel.socket systemd-sysusers.service
 Before=sysinit.target
 ConditionPathIsReadWrite=/sys
 

commit 9ff3e22aa93fe461f8971f2468c65dc928fadc9e
Author: Lennart Poettering <lennart at poettering.net>
Date:   Fri Apr 3 14:26:22 2015 +0200

    CODING_STYLE: mention that dup() should not be used

diff --git a/CODING_STYLE b/CODING_STYLE
index 1748dc4..feb1a9d 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -232,3 +232,10 @@
   "return" to exit from the main function of a process. If you
   fork()ed off a child process, please use _exit() instead of exit(),
   so that the exit handlers are not run.
+
+- Please never use dup(). Use fcntl(fd, F_DUPFD_CLOEXEC, 3)
+  instead. For two reason: first, you want O_CLOEXEC set on the new fd
+  (see above). Second, dup() will happily duplicate your fd as 0, 1,
+  2, i.e. stdin, stdout, stderr, should those fds be closed. Given the
+  special semantics of those fds, it's probably a good idea to avoid
+  them. F_DUPFD_CLOEXEC with "3" as parameter avoids them.