[systemd-commits] src/libsystemd

Tom Gundersen tomegun at kemper.freedesktop.org
Tue Apr 21 05:54:38 PDT 2015


 src/libsystemd/sd-device/sd-device.c |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

New commits:
commit 52d629010db73a9466c359201916494bd55186d1
Author: Tom Gundersen <teg at jklm.no>
Date:   Tue Apr 21 14:41:13 2015 +0200

    sd-device: set_syspath - return ENODEV when passed something that is not a device

diff --git a/src/libsystemd/sd-device/sd-device.c b/src/libsystemd/sd-device/sd-device.c
index 2e30b85..7a7b323 100644
--- a/src/libsystemd/sd-device/sd-device.c
+++ b/src/libsystemd/sd-device/sd-device.c
@@ -184,15 +184,17 @@ int device_set_syspath(sd_device *device, const char *_syspath, bool verify) {
                         path = strjoina(syspath, "/uevent");
                         r = access(path, F_OK);
                         if (r < 0) {
+                                if (errno == ENOENT)
+                                        /* this is not a valid device */
+                                        return -ENODEV;
+
                                 log_debug("sd-device: %s does not have an uevent file: %m", syspath);
                                 return -errno;
                         }
                 } else {
                         /* everything else just just needs to be a directory */
-                        if (!is_dir(syspath, false)) {
-                                log_debug("sd-device: %s is not a directory", syspath);
-                                return -EINVAL;
-                        }
+                        if (!is_dir(syspath, false))
+                                return -ENODEV;
                 }
         } else {
                 syspath = strdup(_syspath);



More information about the systemd-commits mailing list