[systemd-commits] 4 commits - TODO src/journal src/login src/shared

[Lennart Poettering]

 TODO                       |    7 +++++++
 src/journal/journal-file.c |    3 ++-
 src/login/logind-user.c    |    2 +-
 src/shared/calendarspec.c  |    2 +-
 4 files changed, 11 insertions(+), 3 deletions(-)

New commits:
commit 2a560338c471f47ca0caf6f1ec8c54a61e005d7f
Author: Lennart Poettering <lennart at poettering.net>
Date:   Tue Feb 10 12:32:54 2015 +0100

    journald: don't specify inline in local functions
    
    Leave it to the compiler to figure out whether it shall inline stuff or
    not.
    
    Only place where using static inline is OK to use is in in header
    files, really.

diff --git a/src/journal/journal-file.c b/src/journal/journal-file.c
index ec12e89..2845e05 100644
--- a/src/journal/journal-file.c
+++ b/src/journal/journal-file.c
@@ -1963,11 +1963,12 @@ static int test_object_monotonic(JournalFile *f, uint64_t p, uint64_t needle) {
                 return TEST_RIGHT;
 }
 
-static inline int find_data_object_by_boot_id(
+static int find_data_object_by_boot_id(
                 JournalFile *f,
                 sd_id128_t boot_id,
                 Object **o,
                 uint64_t *b) {
+
         char t[sizeof("_BOOT_ID=")-1 + 32 + 1] = "_BOOT_ID=";
 
         sd_id128_to_string(boot_id, t + 9);

commit 5b99bc57f27c0beb37e3d56edbaf70eb1a276531
Author: Lennart Poettering <lennart at poettering.net>
Date:   Tue Feb 10 12:32:19 2015 +0100

    shared: untabify

diff --git a/src/shared/calendarspec.c b/src/shared/calendarspec.c
index 19ae8a3..2fde3e1 100644
--- a/src/shared/calendarspec.c
+++ b/src/shared/calendarspec.c
@@ -24,7 +24,7 @@
 
 #include "calendarspec.h"
 
-#define BITS_WEEKDAYS	127
+#define BITS_WEEKDAYS   127
 
 static void free_chain(CalendarComponent *c) {
         CalendarComponent *n;

commit a9c67ea2a24d61640971fc1ca366a3e6c7d75266
Author: Lennart Poettering <lennart at poettering.net>
Date:   Tue Feb 10 12:31:56 2015 +0100

    logind: tell Coverity that we knowingly ignore mkdir()'s return value

diff --git a/src/login/logind-user.c b/src/login/logind-user.c
index 7b40ef5..f4c4490 100644
--- a/src/login/logind-user.c
+++ b/src/login/logind-user.c
@@ -322,7 +322,7 @@ static int user_mkdir_runtime_path(User *u) {
         if (path_is_mount_point(p, false) <= 0) {
                 _cleanup_free_ char *t = NULL;
 
-                mkdir(p, 0700);
+                (void) mkdir(p, 0700);
 
                 if (mac_smack_use())
                         r = asprintf(&t, "mode=0700,smackfsroot=*,uid=" UID_FMT ",gid=" GID_FMT ",size=%zu", u->uid, u->gid, u->manager->runtime_dir_size);

commit df22b0bbfde403b3fa71f3c2f1e2ca38af946388
Author: Lennart Poettering <lennart at poettering.net>
Date:   Tue Feb 10 12:31:31 2015 +0100

    update TODO

diff --git a/TODO b/TODO
index 0c2a6a4..d3e2b0b 100644
--- a/TODO
+++ b/TODO
@@ -34,6 +34,13 @@ External:
 
 Features:
 
+* generate better errors when people try to set transient properties
+  that are not supported...
+  http://lists.freedesktop.org/archives/systemd-devel/2015-February/028076.html
+
+* nspawn, if stdout/stderr/stdin are non-ttys, don't set up
+  /dev/console, but instead just pass the fds through directly.
+
 * When runlevel3.target is used to define dependencies on other units,
   then we don't pick it up currently, since nothing ever references
   runlevel3.target, and never figure out it actually is just an alias