[systemd-commits] 2 commits - TODO src/bus-proxyd

[Lennart Poettering]

 TODO                    |   14 ++++++++++++++
 src/bus-proxyd/driver.c |    7 ++++---
 2 files changed, 18 insertions(+), 3 deletions(-)

New commits:
commit 20760dcf5df7e253c21a51886cdb02dee612730b
Author: Lennart Poettering <lennart at poettering.net>
Date:   Tue Feb 10 20:46:19 2015 +0100

    update TODO

diff --git a/TODO b/TODO
index d3e2b0b..0daddbf 100644
--- a/TODO
+++ b/TODO
@@ -32,8 +32,22 @@ External:
 * When lz4 gets an API for lz4 command output, make use of it to
   compress coredumps in a way compatible with /usr/bin/lz4.
 
+Before 219:
+
+* revert Kay's revert orgies
+
+* networkd's match bus properties should be "as" instead of "s"
+
 Features:
 
+* coredump: make the handler check /proc/$PID/rlimits for RLIMIT_CORE,
+  and supress coredump if turned off. Then change RLIMIT_CORE to
+  infinity by default for all services. This then allows per-service
+  control of coredumping.
+
+* introduce some call that iterates through cmsg and closes all fds
+  passed in, and use it everywhere...
+
 * generate better errors when people try to set transient properties
   that are not supported...
   http://lists.freedesktop.org/archives/systemd-devel/2015-February/028076.html

commit df3efc3c9008eec6f2d3dc8df997f06758911fc8
Author: Lennart Poettering <lennart at poettering.net>
Date:   Tue Feb 10 20:46:09 2015 +0100

    bus-proxyd: initialize ioctl structure only once

diff --git a/src/bus-proxyd/driver.c b/src/bus-proxyd/driver.c
index b275839..e47c667 100644
--- a/src/bus-proxyd/driver.c
+++ b/src/bus-proxyd/driver.c
@@ -327,7 +327,10 @@ int bus_proxy_process_driver(sd_bus *a, sd_bus *b, sd_bus_message *m, SharedPoli
                 return synthetic_reply_return_strv(m, names);
 
         } else if (sd_bus_message_is_method_call(m, "org.freedesktop.DBus", "ListQueuedOwners")) {
-                struct kdbus_cmd_list cmd = {};
+                struct kdbus_cmd_list cmd = {
+                        .flags = KDBUS_LIST_QUEUED,
+                        .size = sizeof(cmd),
+                };
                 struct kdbus_info *name_list, *name;
                 _cleanup_strv_free_ char **owners = NULL;
                 _cleanup_bus_error_free_ sd_bus_error error = SD_BUS_ERROR_NULL;
@@ -349,8 +352,6 @@ int bus_proxy_process_driver(sd_bus *a, sd_bus *b, sd_bus_message *m, SharedPoli
                 if (r < 0)
                         return synthetic_reply_method_errno(m, r, NULL);
 
-                cmd.flags = KDBUS_LIST_QUEUED;
-                cmd.size = sizeof(cmd);
                 r = ioctl(a->input_fd, KDBUS_CMD_LIST, &cmd);
                 if (r < 0)
                         return synthetic_reply_method_errno(m, -errno, NULL);