[systemd-commits] src/boot
Thomas H.P. Andersen
phomes at kemper.freedesktop.org
Wed Feb 25 14:32:57 PST 2015
src/boot/bootctl.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
New commits:
commit 3a4efbff2e729194d286f483bd8e122c52ff1129
Author: Thomas Hindoe Paaboel Andersen <phomes at gmail.com>
Date: Wed Feb 25 23:10:35 2015 +0100
bootctl: check that partition uuid is valid
It probably is but check anyway to make coverity happy.
CID#1271354
diff --git a/src/boot/bootctl.c b/src/boot/bootctl.c
index fb568be..bd55fa9 100644
--- a/src/boot/bootctl.c
+++ b/src/boot/bootctl.c
@@ -177,7 +177,13 @@ static int verify_esp(const char *p, uint32_t *part, uint64_t *pstart, uint64_t
fprintf(stderr, "Failed to probe partition entry UUID %s: %s\n", p, strerror(-r));
goto fail;
}
- sd_id128_from_string(v, uuid);
+
+ r = sd_id128_from_string(v, uuid);
+ if (r < 0) {
+ fprintf(stderr, "Partition %s has invalid UUID: %s\n", p, v);
+ r = -EIO;
+ goto fail;
+ }
errno = 0;
r = blkid_probe_lookup_value(b, "PART_ENTRY_NUMBER", &v, NULL);
More information about the systemd-commits
mailing list