[systemd-commits] CODING_STYLE

[Lennart Poettering]

 CODING_STYLE |   14 ++++++++++++++
 1 file changed, 14 insertions(+)

New commits:
commit 918315e457ca36cab94ff3b6060e143968c99ace
Author: Lennart Poettering <lennart at poettering.net>
Date:   Tue Mar 10 17:39:42 2015 +0100

    CODING_STYLE: mention casting of function invocations to (void)

diff --git a/CODING_STYLE b/CODING_STYLE
index 0340ff0..b687e72 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -212,3 +212,17 @@
 - Use the bool type for booleans, not integers. One exception: in public
   headers (i.e those in src/systemd/sd-*.h) use integers after all, as "bool"
   is C99 and in our public APIs we try to stick to C89 (with a few extension).
+
+- When you invoke certain calls like unlink(), or mkdir_p() and you
+  know it is safe to ignore the error it might return (because a later
+  call would detect the failure anyway, or because the error is in an
+  error path and you thus couldn't do anything about it anyway), then
+  make this clear by casting the invocation explicitly to (void). Code
+  checks like Coverity understand that, and will not complain about
+  ignored error codes. Hence, please use this:
+
+      (void) unlink("/foo/bar/baz");
+
+  instead of just this:
+
+      unlink("/foo/bar/baz");