[systemd-commits] src/test

Tom Gundersen tomegun at kemper.freedesktop.org
Mon May 25 14:11:41 PDT 2015


 src/test/test-util.c |    7 +++++++
 1 file changed, 7 insertions(+)

New commits:
commit e136009df20f02e8f4e1dc179da58e3fbd93342c
Author: Tom Gundersen <teg at jklm.no>
Date:   Mon May 25 23:10:26 2015 +0200

    test: hostname - test that hostname is truly initialized
    
    Fixes CID CID 1299638 (use after free).

diff --git a/src/test/test-util.c b/src/test/test-util.c
index 36773c1..41cbe81 100644
--- a/src/test/test-util.c
+++ b/src/test/test-util.c
@@ -563,24 +563,31 @@ static void test_read_hostname_config(void) {
         assert_se(read_hostname_config(path, &hostname) == 0);
         assert_se(streq(hostname, "foo"));
         free(hostname);
+        hostname = NULL;
 
         /* with comment */
         write_string_file(path, "# comment\nfoo");
         assert_se(read_hostname_config(path, &hostname) == 0);
+        assert_se(hostname);
         assert_se(streq(hostname, "foo"));
         free(hostname);
+        hostname = NULL;
 
         /* with comment and extra whitespace */
         write_string_file(path, "# comment\n\n foo ");
         assert_se(read_hostname_config(path, &hostname) == 0);
+        assert_se(hostname);
         assert_se(streq(hostname, "foo"));
         free(hostname);
+        hostname = NULL;
 
         /* cleans up name */
         write_string_file(path, "!foo/bar.com");
         assert_se(read_hostname_config(path, &hostname) == 0);
+        assert_se(hostname);
         assert_se(streq(hostname, "foobar.com"));
         free(hostname);
+        hostname = NULL;
 
         /* no value set */
         hostname = (char*) 0x1234;



More information about the systemd-commits mailing list