[systemd-commits] src/libsystemd

Tom Gundersen tomegun at kemper.freedesktop.org
Thu May 28 08:36:15 PDT 2015


 src/libsystemd/sd-device/device-enumerator.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 5f529f4c97a141457301477505ae7eb4c28cf610
Author: Tom Gundersen <teg at jklm.no>
Date:   Thu May 28 17:18:33 2015 +0200

    sd-device: enumerator - fix matching on properties and sysattrs
    
    This was a regression that broke
    
      $ udevadm trigger -nv --property-match=DEVNAME=/dev/sda1 --attr-match=size=409600
    
    Reported by David Reisner.

diff --git a/src/libsystemd/sd-device/device-enumerator.c b/src/libsystemd/sd-device/device-enumerator.c
index ce4862d..3692d46 100644
--- a/src/libsystemd/sd-device/device-enumerator.c
+++ b/src/libsystemd/sd-device/device-enumerator.c
@@ -367,11 +367,11 @@ static bool match_sysattr(sd_device_enumerator *enumerator, sd_device *device) {
         assert(enumerator);
         assert(device);
 
-        HASHMAP_FOREACH_KEY(sysattr, value, enumerator->nomatch_sysattr, i)
+        HASHMAP_FOREACH_KEY(value, sysattr, enumerator->nomatch_sysattr, i)
                 if (match_sysattr_value(device, sysattr, value))
                         return false;
 
-        HASHMAP_FOREACH_KEY(sysattr, value, enumerator->match_sysattr, i)
+        HASHMAP_FOREACH_KEY(value, sysattr, enumerator->match_sysattr, i)
                 if (!match_sysattr_value(device, sysattr, value))
                         return false;
 
@@ -389,7 +389,7 @@ static bool match_property(sd_device_enumerator *enumerator, sd_device *device)
         if (hashmap_isempty(enumerator->match_property))
                 return true;
 
-        HASHMAP_FOREACH_KEY(property, value, enumerator->match_property, i) {
+        HASHMAP_FOREACH_KEY(value, property, enumerator->match_property, i) {
                 const char *property_dev, *value_dev;
 
                 FOREACH_DEVICE_PROPERTY(device, property_dev, value_dev) {



More information about the systemd-commits mailing list