[systemd-devel] [patch] cgroup fs: avoid switching ->d_op on live dentry

[Sedat Dilek]

On Tue, Dec 21, 2010 at 9:44 AM, Sedat Dilek <sedat.dilek at googlemail.com> wrote:
> Against linux-next (next-20101210) it should look like:
>
> $ diff -Naur cgroup-fix/cgroup-fs-avoid-switching-d_op-on-live-dentry.patch
> cgroup-fix/cgroup-fs-avoid-switching-d_op-on-live-dentry-v2.patch
> --- cgroup-fix/cgroup-fs-avoid-switching-d_op-on-live-dentry.patch
>  2010-12-21 09:31:38.649601964 +0100
> +++ cgroup-fix/cgroup-fs-avoid-switching-d_op-on-live-dentry-v2.patch
>  2010-12-21 09:40:21.151033232 +0100
> @@ -83,7 +83,7 @@
>                inode->i_size = 0;
>                inode->i_fop = &cgroup_file_operations;
>        }
> --      dentry->d_op = &cgroup_dops;
> +-      d_set_d_op(dentry, &cgroup_dops);
>        d_instantiate(dentry, inode);
>        dget(dentry);   /* Extra count - pin the dentry in core */
>        return 0;
>
> - Sedat -
>

YAY!!!

# dmesg | grep systemd
[    0.000000] Kernel command line:
BOOT_IMAGE=/boot/vmlinuz-2.6.37-rc6-686
root=UUID=1ceb69a7-ecf4-47e9-a231-b74e0f0a9b62 ro ini
[    4.124563] systemd[1]: systemd 15 running in system mode. (+PAM
-LIBWRAP -AUDIT +SELINUX +SYSVINIT -LIBCRYPTSETUP; debian)
[    4.246090] systemd[1]: Set hostname to <tbox>.
[    6.942949] systemd-logger[290]: Got error on stream: No such
process
[    9.011378] systemd-fsck[524]: /dev/sda3: sauber, 128062/640848
Dateien, 1839774/2560359 Blöcke
[   15.186112] systemd[1]: ifupdown-clean.service: control process
exited, code=exited status=209
[   15.186941] systemd[1]: Unit ifupdown-clean.service entered failed state.
[   15.187363] systemd[1]: mountoverflowtmp.service: control process
exited, code=exited status=209
[   15.206223] systemd[1]: Unit mountoverflowtmp.service entered failed state.
[   15.215739] systemd[1]: resolvconf.service: control process exited,
code=exited status=209
[   15.235257] systemd[1]: Unit resolvconf.service entered failed state.

Feel free to add:

       Reported-and-tested-by: Sedat Dilek <sedat.dilek at gmail.com>

(Tested with the above v2 patch against linux-next (next-20101221) -
see file attachment).

- Sedat -
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cgroup-fs-avoid-switching-d_op-on-live-dentry-v2.patch
Type: plain/text
Size: 3276 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20101221/57b14755/attachment.bin>