[systemd-devel] [PATCH] buildsys: allow building without libnotify

[Henry Gebhardt]

On Fri, Nov 26, 2010 at 06:02:28PM +0100, Kay Sievers wrote:
> On Fri, Nov 26, 2010 at 16:47, Kay Sievers <kay.sievers at vrfy.org> wrote:
> > On Fri, 2010-11-26 at 00:45 +0100, Kay Sievers wrote:
> >> On Thu, 2010-11-25 at 21:53 +0300, Andrey Borzenkov wrote:
> >> > On Thu, Nov 25, 2010 at 8:49 PM, Kay Sievers <kay.sievers at vrfy.org> wrote:
> >> > > On Wed, 2010-11-24 at 21:20 +0100, Lennart Poettering wrote:
> >> > >> On Wed, 24.11.10 11:57, Kay Sievers (kay.sievers at vrfy.org) wrote:
> >> > >> > On Wed, Nov 24, 2010 at 08:36, Thierry Reding
> >> > >> > <thierry.reding at avionic-design.de> wrote:
> >> > >> > > This patch makes the libnotify dependency optional and doesn't build the
> >> > >> > > systemd-gnome-ask-password-agent utility if libnotify is not available.
> >> > >> > >
> >> > >> > > Since libnotify >= 0.7.0 requires gtk+-3.0, this patch may be useful for
> >> > >> > > environments where upgrading Gtk is not an option.
> >> > >> >
> >> > >> > Yeah, would be good to solve that. Maybe that's the simplest way to do it.
> >> > >> >
> >> > >> > One other option would be to use some #ifdef in vala und also support
> >> > >> > the still common older libnotify.
> >> > >>
> >> > >> I'd be happy to take a patch which uses vala's new ifdef support to
> >> > >> make the gtk stuff buildable on both old and new libnotify. If somebody
> >> > >> cares enough.
> >> > >
> >> > > Untested and really ugly. :)
> >> > >
> >> >
> >> > tested with vala 0.10.1 and libnotify 0.4.5.
> >> >
> >> > Cannot comment on ugliness :)
> >>
> >> Here is an updated patch. Seems to work here with the old libnotify, but
> >> 'make distcheck' still fails.
> >
> > Ok vala autotools need to be worked-around. That patch works fine for me
> > for the old libnotify.
> >
> > Harald, Matthias could anyone of you check if that still compiles with
> > libnotify 0.7 in rawhide, then I'll go an commit it.
> 
> Seems to work. Committed.
> 

Hm, when using "./configure --disable-gtk", I get the error

...
checking for /etc/gentoo-release... yes
checking for /etc/slackware-version... no
configure: error: conditional "LIBNOTIFY07" was never defined.
Usually this means the macro was only invoked conditionally.

Thanks,
Henry