[systemd-devel] Forgot break in switch? (+ PATCH)

[Matthias Schiffer]

 As I didn't get any comments on my last mail, I'm trying again, now
with a patch attached :-D

I don't know if this patch is correct or if there is any reason that
break is missing, but applying it fixes an assertion fail for me.
systemd hits the assertion in the default branch of the switch when I
have a failing timer unit and call daemon-reload.

On 09/29/2010 03:23 PM, Matthias Schiffer wrote:
>  Hi,
> the single semicolon in timer.c:433 (git ee95669) looks strange, was it
> meant to be a break?
>
> This causes systemd to crash at the assertion on my Arch system whenever
> I call daemon-reload (yes, I have some failing units, I haven't set up
> everything correctly for Arch yet; I think, this is connected to
> tmpwatch.timer, as I haven't installed tmpwatch). Putting a break there
> fixes this.
>
> Matthias
>
>
>
> _______________________________________________
> systemd-devel mailing list
> systemd-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/systemd-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20101001/49c64436/attachment.htm>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-timer-Add-missing-break-in-switch.patch
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20101001/49c64436/attachment.txt>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20101001/49c64436/attachment.pgp>