[systemd-devel] Debian patches, typo fixes

[Santi Béjar]

On Fri, Sep 10, 2010 at 2:58 PM, Michael Biebl <mbiebl at gmail.com> wrote:
> 2010/9/10 Santi Béjar <santi at agolina.net>:
>> Hi *,
>>
>> On Thu, Sep 9, 2010 at 2:22 PM, Jens Persson <xerxes2 at gmail.com> wrote:
>>> Try to put your check services in sysinit.target.wants and add
>>> After=sysinit.target to local-fs.target.
>>
>> I've tried something like this. But first let me correct my report,
>> the patch breaking my boot is the one introducing a separated
>> fsck.target:
>>
>> v9-8-gf10814d (units: Provide separate fsck.target for Debian, 2010-09-03)
>
> Interesting. I have a separate /home partition and it works just fine for me.

Interesting, interesting.

>
>>
>> I've applied this patch without success:
>>
>> diff --git i/units/debian/fsck.target w/units/debian/fsck.target
>> index 5da9a4f..b4aaf5c 100644
>> --- i/units/debian/fsck.target
>> +++ w/units/debian/fsck.target
>> @@ -9,3 +9,5 @@
>>
>>  [Unit]
>>  Description=File System Check
>> +Wants=checkroot.service checkfs.service
>> +After=checkroot.service checkfs.service
>>
>> The ordering would be:
>>
>> 1) checkroot.service checkfs.service
>> 2) fsck.target
>> 3) home.mount
>>
>
> You mean, it should be, but it is not?

I mean that I expect this to be the order, but reality does not agree
with me as checkfs.service is run after home.mount and it fails.

>
>> but the home partition is still mounted before checkfs is run.
>>
>> Here it is the relevant info about these units:
>>
>> $ systemctl show checkfs.service
>> Id=checkfs.service
>> Names=checkfs.service
>> WantedBy=sysinit.target fsck.target
>> Before=mountall.service sysinit.target fsck.target
>> After=checkroot.service mtab.service cryptdisks.service
>> Description=LSB: Check all filesystems.
>> ...
>>
>> $ systemctl show fsck.target
>> Id=fsck.target
>> Names=fsck.target
>> Wants=checkroot.service checkfs.service
>> ConflictedBy=shutdown.target
>> Before=tmp.mount media-cdrom0.mount home.mount
>> sys-fs-fuse-connections.mount lib-init-rw.mount
>> After=checkroot.service checkfs.service
>> Description=File System Check
>> ...
>>
>> $ systemctl show home.mount
>> Id=home.mount
>> Names=home.mount
>> Requires=dev-disk-by\x1duuid-7bea11bc\x1de5c6\x1d429b\x1d80b1\x1dac2763026e01.device
>> -.mount
>> WantedBy=local-fs.target
>> ConflictedBy=umount.target
>> Before=local-fs.target umount.target
>> After=dev-disk-by\x1duuid-7bea11bc\x1de5c6\x1d429b\x1d80b1\x1dac2763026e01.device
>> fsck.target -.mount
>> Description=/home
>
> Hm, I might be overlooking something, but that looks ok to me.

As said in another post I´ll try adding a Wants=fsck.target to
home.mount or WantedBy=home.mount to fsck.target.

Santi