[systemd-devel] [PATCH] gentoo: vconsole-setup support.
lennart at poettering.net
Mon Sep 20 14:30:39 PDT 2010
On Mon, 20.09.10 18:03, Gustavo Sverzut Barbieri (barbieri at profusion.mobi) wrote:
> On Mon, Sep 20, 2010 at 5:44 PM, Lennart Poettering
> <lennart at poettering.net> wrote:
> > On Sun, 19.09.10 21:23, Gustavo Sverzut Barbieri (barbieri at profusion.mobi) wrote:
> > Heya,
> > Looks pretty good, but a few requests:
> >> +#ifdef TARGET_GENTOO
> >> +/* Gentoo uses sys-apps/kbd that installs to /usr and have fonts in CamelCase */
> >> +#define KBD_LOADKEYS "/usr/bin/loadkeys"
> >> +#define KBD_SETFONT "/usr/bin/setfont"
> >> +#define DEFAULT_FONT "LatArCyrHeb-16"
> >> +#else
> >> +#define KBD_LOADKEYS "/bin/loadkeys"
> >> +#define KBD_SETFONT "/bin/setfont"
> >> +#define DEFAULT_FONT "latarcyrheb-sun16"
> >> +#endif
> > I think it would be nicer if the path and filename configuration would
> > happen in the Makefile, instead of in the sources. Could you move this
> > to Makefile.am?
> yes I could... but I fear getting an exponential number of configure
> options... or you mean just the Makefile.am and not configure.ac? what
> would be the configure.ac option name that you like?
Just Makefile.am, not configure.ac.
> > Please use parse_boolean() here, which does pretty much exactly what you
> > want to do here, but is much nicer to read.
> well... not 100% as you just match the first letter of yes/true, but
> yeah, who cares... I'll change that and send the new version.
Well, as long as we check a superset of the acceptable Gentoo syntaxes
we should be fine ;-)
Lennart Poettering - Red Hat, Inc.
More information about the systemd-devel