[systemd-devel] PgSQL, MySQL systemd services - how to rewrite complex init scripts?

[Lennart Poettering]

On Sat, 09.04.11 12:15, Gustavo Sverzut Barbieri (barbieri at profusion.mobi) wrote:

> 2011/4/9 Michał Piotrowski <mkkp4x4 at gmail.com>:
> > Hi,
> >
> > I want to rewrite postgresql and mysqld init scripts for my system
> > (later, of course, I want to share them with others) and I wonder if
> > there are any recomendations how to rewrite complex scripts.
> >
> > Postgresql script has perform_initdb(), initdb() and upgrade()
> > functions. IMO these functions should be in separated script. The
> > problem is that there are some database format version checks. IMO
> > these checks are very important, so maybe it would be a good way to
> > move them to separated script and run them with ExecStartPre? But what
> > happens when this script exits because database format is old and
> > needs an update? How to handle such situation?
> >
> > Mysql script also has some data dir creation code - I think it can
> > also be moved to separated script.
> 
> As mentioned with handful similar cases: this should be handled as
> part of the daemon itself, not initscript.  That's the final solution
> we should aim as it's the only sane place to do it.

Yes, this is my opinion, too. Daemons should handle these things
automatically instead of relying on external per-distro shell code to do
these things.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.