[systemd-devel] [PATCH] systemctl: implement auto-pager a la git

[Lennart Poettering]

On Tue, 04.01.11 14:20, Tollef Fog Heen (tfheen at err.no) wrote:

> 
> ]] Lennart Poettering 
> 
> | Hmm, so, given that we check PAGER ourselves, calling sensible-pager is
> | of little benefit for us, right? And I probably should change the
> | invocation of sensible-pager to pager in my code, so that we search for
> | "pager", "less" and "more" in this order?
> 
> Sounds fine.

OK, commited this change.

> | (That shell script sucks btw, it should invoke the pager with 'exec'.)
> 
> No, since if /bin/sh is dash (at least), you'd then not fall through if
> the exec failed due to PAGER pointing to a missing executable.

Hmpf. This sounds very much broken, I can't believe POSIX allows that.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.