[systemd-devel] [PATCH] ExecConfigTest first try

[Mirco Tischler]

Am 11.01.2011 17:40, schrieb Alexander E. Patrakov:
> 11.01.2011 21:11, Mirco Tischler wrote:
>
> <a patch>
>
> Sorry, this doesn't work as expected. To reproduce the problem:
> 1) Start a service with a good config
> 2) Edit the config. Make a typo.
> 3) Attempt to reload the service. At this point, systemd will put the
> whole service into a "failed" state.
> 4) Fix the typo.
> 5) Attempt to reload the service.
>
> Expected result: service reloaded with the new config.
> Actual result: systemd doesn't let me reload the service.
>
> Also, when starting a service, systemd tests the config twice for some
> reason. And it is really strange that in the system log with
> systemd.log_level=debug systemd.log_target=kmsg, systemd attempts to
> fork the main command before the check finished and thus seems to run
> the main command in parallel with the check. In other words, I doubt
> that the correct thing is tested. I suspect that "the executable is
> found" fact is tested, not "the command executed successfully".
Thanks for testing it. I didn't expect it to do the right thing yet ;)
All the tests I was able to run for reasons of limited time was service
start, restart and reload without.
Seems I need to read the sources a little more. Some of them could
really use more commenting. :)
A second version will follow probably next week.

And sorry for the patch send twice. The first version was mangled by my
mailclient so I tried git send-email on the second one.

Thanks
Mirco