[systemd-devel] [PATCH] buildsys: don't look for vala without --enable-gtk

Tom Gundersen teg at jklm.no
Fri Jan 21 09:08:20 PST 2011


On Fri, Jan 21, 2011 at 5:45 PM, Lennart Poettering
<lennart at poettering.net> wrote:
> On Thu, 20.01.11 23:08, Dave Reisner (d at falconindy.com) wrote:
>
>> if --disable-gtk is passed, vala is no longer a build dependency. under
>> these conditions, configure should not fail when vala 0.10 is found.
>
> Vala is required only if you build from git. If you build from tarball
> the .c files are pre-generated for you and there is no Vala
> dependency. Your patch hence makes little sense since we write the
> configure script for tarball installs, and you are expected to install
> more stuff if you build from git, including autoconf and automake
> itself, and vala.

In Arch at the moment, we only have vala 0.10. This is fine for me, as
I don't care about the vala parts of systemd, so I just removed vala
from my system and systemd from git compiles fine. However, I guess
for other people who might have vala installed for other purposes, it
would make sense to be allowed to build (the non-vala partst of)
systemd from git.

In other words, why not treat "vala < 0.11" the same way as we treat
"no vala at all" (which I thought was the intention of Dave's patch)?

Cheers,

Tom


More information about the systemd-devel mailing list