[systemd-devel] [PATCH] Add the most common consoles that MeeGo needs

[Chris Ferron]

On 07/01/2011 11:15 AM, Koen Kooi wrote:
> Op 1 jul 2011, om 20:02 heeft Chris Ferron het volgende geschreven:
>
>> On 07/01/2011 10:11 AM, Koen Kooi wrote:
>>> Op 1 jul 2011, om 18:19 heeft Chris Ferron het volgende geschreven:
>>>
>>>> MeeGo will use several consoles depending on the hardware adaptations.
>>>> This patch adds the most common to the serial-getty unit Install section so when systemd is built for MeeGo as its distribution, you get the most common Aliased for installation by the user.
>>>>
>>>>
>>>>
>>>>  From c50559ea74069061401c8a218d73d515d7b9cd09 Mon Sep 17 00:00:00 2001
>>>> From: Chris Ferron<chris.e.ferron at linux.intel.com>
>>>> Date: Fri, 1 Jul 2011 08:54:37 -0700
>>>> Subject: [PATCH] Add the most common consoles that MeeGo as a distribution
>>>>   will need.
>>>>
>>>> ---
>>>>   units/serial-getty at .service.m4 |    9 +++++++++
>>>>   1 files changed, 9 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/units/serial-getty at .service.m4 b/units/serial-getty at .service.m4
>>>> index 082290c..aea47be 100644
>>>> --- a/units/serial-getty at .service.m4
>>>> +++ b/units/serial-getty at .service.m4
>>>> @@ -9,6 +9,9 @@
>>>>   Description=Serial Getty on %I
>>>>   BindTo=dev-%i.device
>>>>   After=dev-%i.device systemd-user-sessions.service plymouth-quit-wait.service
>>>> +m4_ifdef(`TARGET_MEEGO',
>>>> +After=dev-%i.device systemd-user-sessions.service
>>>> +)m4_dnl
>>>>   m4_ifdef(`TARGET_FEDORA',
>>>>   After=rc-local.service
>>>>   )m4_dnl
>>>> @@ -44,3 +47,9 @@ KillMode=process
>>>>   # Some login implementations ignore SIGTERM, so we send SIGHUP
>>>>   # instead, to ensure that login terminates cleanly.
>>>>   KillSignal=SIGHUP
>>>> +
>>>> +m4_ifdef(`TARGET_MEEGO',
>>>> +[Install]
>>>> +Alias=sysinit.target.wants/serial-getty at ttyS0.service sysinit.target.wants/serial-getty at ttyS1.service sysinit.target.wants/serial-getty at tty01.service sysinit.target.wants/serial-getty at ttyO2.service
>>>> +)m4_dnl
>>> An a lot of OMAP systems ttyO1 is hooked up to the bluetooth UART, so I don't know how usefull running a getty on that is.
>>>
>>> regards,
>>>
>>> Koen
>> Thanks for the comment. There may be a good amount of OMAP systems that will use tty01 as a non console.
>> But this change should only be included in the MeeGo distribution. In MeeGo at this time we do not have any OMAP adaptations that have this behaviour,
> Beagleboard and pandaboard have bluetooth on ttyO1 and meego runs on that, or have I misunderstood.
No you did not misunderstand. There are some who have been using 
beagleboards and pandaboards with MeeGo, and that is great. But I know 
of no hard plan to have full MeeGo support for them. *BUT* that may change.
Regardless, in the event that it changes, any vertical that uses an OMAP 
system would just not enable tty01, but would enable the tty that they 
need.

There are several options used in MeeGo with its current hardware 
adaptations. We are only up-streaming the support option for the most 
common, but not forcing.

Your point is a good one to consider, but I think this solution will work.
>> but we do have supported hardware adaptations that do use tty01 as a console.
>>
>> So for MeeGo we want the Aliases so that if users using MeeGo on a supported hardware adaptations want to enable the tty01 then they can.
>> As Aliases do not mean the tty* will spawn, they are a perfect for giving the users in MeeGo the support and option.
> Ok