[systemd-devel] [PATCH] fix bogus boot error message

[Kelly Anderson]

On 07/19/11 06:04, Kay Sievers wrote:
> On Tue, Jul 19, 2011 at 13:22, Kelly Anderson
> <kelly at silka.with-linux.com>  wrote:
>> The following commit introduces a bogus error message on boot since
>> localtime may be a negative number, i.e. GMT-7.
>> The following patch just uses errno directly rather than using it indirectly
>> through hwclock_apply_localtime_delta():
> Ah, tm->tm_gmtoff can be negative.
>
>> +       errno = 0;
>>           min = hwclock_apply_localtime_delta();
> We usually prefer to return the errno instead of mangling it at the
> caller's side, and have the values that can be negative passed as
> arguments. Mind switching that? Or let me know.
>
> Thanks,
> Kay
Something along the lines of:

int status = hwclock_apply_localtime_delta(&min)

Is that what you mean?  If that's what you're looking for, I could do that.