[systemd-devel] [PATCH] trivial memory leak in sysv_translate_facility()

Lennart Poettering lennart at poettering.net
Sun Mar 6 14:46:49 PST 2011


On Fri, 04.03.11 16:54, Andrey Borzenkov (arvidjaar at gmail.com) wrote:

Heya,

> If we ever expect caller to not be interested in allocated
> string, this string should be freed in this case.

Hmm, there's an assert(_r) in the header of the function. Which I guess
makes the whole 'if' check unnecessary. To simplify things I have now
dropped the check instead of merging your patch.

Thanks a lot nonetheless!

> Signed-off-by: Andrey Borzenkov <arvidjaar at gmail.com>

(BTW, we don't do S-o-b, we're not the kernel)

Lennart

-- 
Lennart Poettering - Red Hat, Inc.


More information about the systemd-devel mailing list