[systemd-devel] [PATCH 2/2] dbus: add service D-Bus property "Sockets"

Andrey Borzenkov arvidjaar at gmail.com
Fri Mar 11 10:09:28 PST 2011


On Fri, Mar 11, 2011 at 9:01 PM, Lennart Poettering
<lennart at poettering.net> wrote:
> B1;2790;0cOn Fri, 11.03.11 15:26, Andrey Borzenkov (arvidjaar at gmail.com) wrote:
>
>> Support displaying of Sockets for a service. Renames
>> bus_unit_append_dependencies into bus_properties_append_units
>> as this is what it really does.
>
> Looks good, too, but I think bus_unit_append_dependencies() is a better
> name, since bus_property_append_xxxx() is really just for the most
> basic types.
>

What about bus_unit_append_units then? I really wanted to avoid it :)

It is no more just dependencies, so I'd really prefer to rename it.


More information about the systemd-devel mailing list