[systemd-devel] crypto: to show stars or not to show them

[Jan Engelhardt]

On Tuesday 2011-03-29 19:18, Lennart Poettering wrote:

>On Tue, 29.03.11 19:17, Jan Engelhardt (jengelh at medozas.de) wrote:
>
>> >> >I have now fixed git to accept both TAB and BS as silent mode switch
>> >> >key. TAB at any time, and BS only if pressed as very first key on the
>> >> >prompt. 
>> >> >Everybody happy?
>> >> 
>> >> No. We don't need two keys to perform the same action. \t can go away.
>> >
>> >I think it has one big advantage: if you types something and then want
>> >to hide it you can use that. Think: you type your passphrase, you notice
>> >somebody looks over your shoulder, you press TAB and he's left in the
>> >dark.
>> 
>> You did not seem to have troubles with the stars, so why are you now 
>> discontent with how they are hidden? This \t thing and switching to 
>> noecho mode on the Nth key smells terribly like overdesign.
>
>Does it? It's a two line change.
>
>I think discussing this much longer smells terribly like
>bikeshedding... ;-)

No, this is criticism (from my side). A few days ago you were a strict 
proponent of echo mode, and now add noecho mode patches unilaterally. 
Why even listen? Rambo merge it! Since you seem to know better what we 
need, just rip out my code.