[systemd-devel] [PATCH] util: arg 'nbytes' of loop_read/write should be of type ssize_t

Kay Sievers kay.sievers at vrfy.org
Mon May 2 09:41:17 PDT 2011


On Mon, May 2, 2011 at 05:18, fykcee1 at gmail.com <fykcee1 at gmail.com> wrote:
>  loop_read/write will try to fill/read 'nbytes' of caller supplying buffer.
> This argument is currently of type size_t, which is always true
> for loop quit condition "while (nbytes > 0)", hence we change it to
> type ssize_t here.

Where would that be useful? It's the size of the buffer supplied to
the function, just like read() itself has.

> This also helps to detect passed-in 'nbytes' of value -1
> for example.

Detect what that way, a negative sizeof()?

Kay


More information about the systemd-devel mailing list