[systemd-devel] [PATCH] src/util.h: include `stdarg.h`

[Lennart Poettering]

On Mon, 02.05.11 18:33, Paul Menzel (paulepanter at users.sourceforge.net) wrote:

> Date: Mon, 2 May 2011 14:13:08 +0200
> 
> Otherwise using uClibc compilation (OpenEmbedded [1] with
> `minimal-uclibc` for `MACHINE = "beagleboard"`) fails with the
> following error message.

> --- a/src/util.h
> +++ b/src/util.h
> @@ -25,6 +25,7 @@
>  #include <inttypes.h>
>  #include <time.h>
>  #include <sys/time.h>
> +#include <stdarg.h>
>  #include <stdbool.h>
>  #include <stdlib.h>
>  #include <stdio.h>

Hmm, this should be enough to include in util.c, not util.h, right?

Normally I'd say that it is uclibc's job to ensure compat with
glibc. But in this case I think it actually makes sense to include this,
because we do use va_xxx and friends in util.c.

Can you rework and test the patch if you include this in util.c rather
then util.h? I'd be willing to merge such a patch then.

Lennart

-- 
Lennart Poettering - Red Hat, Inc.