[systemd-devel] [PATCH] Angstrom support

[Koen Kooi]

Op 5 mei 2011, om 19:54 heeft Gustavo Sverzut Barbieri het volgende geschreven:

> On Thu, May 5, 2011 at 1:17 PM, Harald Hoyer <harald.hoyer at gmail.com> wrote:
>>> diff --git a/src/util.c b/src/util.c
>>> index f0051ee..5af9161 100644
>>> --- a/src/util.c
>>> +++ b/src/util.c
>>> @@ -3426,6 +3426,18 @@ void status_welcome(void) {
>>> 
>>>         if (!ansi_color)
>>>                 const_color = "1;35"; /* Bright Magenta for MeeGo */
>>> +#elif defined(TARGET_ANGSTROM)
>>> +
>>> +        if (!pretty_name) {
>>> +                if ((r = read_one_line_file("/etc/angstrom-version", &pretty_name)) < 0) {
>>> +
>>> +                        if (r != -ENOENT)
>>> +                                log_warning("Failed to read /etc/angstrom-version: %s", strerror(-r));
>>> +                }
>>> +        }
>>> +
>>> +       if (!ansi_color)
>>> +               const_color = "1;35"; /* Bright Magenta for Angstrom */
>>>  #endif
>>> 
>>>          if (!pretty_name && !const_pretty)
>>> 
>>> 
>>> 
>> 
>> 
>> Hmm, wouldn't it make sense to symlink
>> 
>> "/etc/SuSE-release"
>> "/etc/gentoo-release"
>> "/etc/altlinux-release"
>> "/etc/debian_version"
>> "/etc/mandriva-release"
>> "/etc/meego-release"
>> 
>> to "/etc/system-release" or provide "/etc/lsb-release" ???
>> 
>> All those #ifdefs are taking overhand...
> 
> that would be good! :-) but who has the right/final-world to get these
> distros to do it?
> 
> Maybe Koen is in that position with Angstron? :-)

I'm open to making /etc/os-release work and all, but for the patch I just copied what the other distros are doing :) It is a bit of a chicken and egg situation to be honest.

> BTW, what's the
> feasibility to have Angstron as use systemd by default?

I'd like that to happen, but first it needs to work :) I'm not even getting a getty on serial or fbcon:

[   96.019958] <28>systemd[1]: Job dev-ttyO2.device/start timed out.
[   96.026489] <31>systemd[1]: Job dev-ttyO2.device/start finished, result=timeout
[   96.034362] <31>systemd[1]: Job getty at ttyO2.service/start finished, result=dependency
[   96.042877] <29>systemd[1]: Job getty at ttyO2.service/start failed with result 'dependency'.

But that's slight off-topic :)

regards,

Koen