[systemd-devel] [PATCH] Angstrom support

[Koen Kooi]

Op 5 mei 2011, om 19:54 heeft Gustavo Sverzut Barbieri het volgende geschreven:

> On Thu, May 5, 2011 at 1:17 PM, Harald Hoyer <harald.hoyer at gmail.com> wrote:
>>> diff --git a/src/util.c b/src/util.c
>>> index f0051ee..5af9161 100644
>>> --- a/src/util.c
>>> +++ b/src/util.c
>>> @@ -3426,6 +3426,18 @@ void status_welcome(void) {
>>> 
>>>         if (!ansi_color)
>>>                 const_color = "1;35"; /* Bright Magenta for MeeGo */
>>> +#elif defined(TARGET_ANGSTROM)
>>> +
>>> +        if (!pretty_name) {
>>> +                if ((r = read_one_line_file("/etc/angstrom-version", &pretty_name)) < 0) {
>>> +
>>> +                        if (r != -ENOENT)
>>> +                                log_warning("Failed to read /etc/angstrom-version: %s", strerror(-r));
>>> +                }
>>> +        }
>>> +
>>> +       if (!ansi_color)
>>> +               const_color = "1;35"; /* Bright Magenta for Angstrom */
>>>  #endif
>>> 
>>>          if (!pretty_name && !const_pretty)
>>> 
>>> 
>>> 
>> 
>> 
>> Hmm, wouldn't it make sense to symlink
>> 
>> "/etc/SuSE-release"
>> "/etc/gentoo-release"
>> "/etc/altlinux-release"
>> "/etc/debian_version"
>> "/etc/mandriva-release"
>> "/etc/meego-release"
>> 
>> to "/etc/system-release" or provide "/etc/lsb-release" ???
>> 
>> All those #ifdefs are taking overhand...
> 
> that would be good! :-) but who has the right/final-world to get these
> distros to do it?
> 
> Maybe Koen is in that position with Angstron? :-) 

Angstrom now provides /etc/os-release and the offending hunk has been dropping in the V2 version of the patch. Anything else that needs to get addressed before the patch can go in?

regards,

Koen