[systemd-devel] [PATCH] {locale, vconsole}-setup.c: unconditionally read config file settings

[Lennart Poettering]

On Wed, 04.05.11 10:28, Harald Hoyer (harald at redhat.com) wrote:

> 
> Am 03.05.2011 18:02, schrieb Lennart Poettering:
> > On Tue, 03.05.11 16:39, harald at redhat.com (harald at redhat.com) wrote:
> > 
> >> From: Harald Hoyer <harald at redhat.com>
> >>
> >> systemd-vconsole-setup did not process any configuration files, if it
> >> found at least one parameter on the kernel command line.
> >>
> >> First we should read all config file parameter settings and let them
> >> be overwritten by kernel command line parameters afterwards.
> > 
> > Hmm, we actually did things like this on purpose, in order to avoid
> > "mixed" configurations. i.e. if you set "LANG=de_DE" on the kernel
> > command line you would probably be very much annoyed if LC_MESSAGES=C
> > which you set in the config file would still hold.
> > 
> > Hence we decided to either take the set of config options altogther or
> > none at all, but not try to merge them.
> > 
> > Does that make sense to you?
> 
> No it does not. If I set a different keymap, I want the font to be the same as
> before.

Hmm, it makes sense to make keymap and font independently settable, that
is true.

I'd be happy to take a patch for that, and also added this to the TODO
list.

Basically, the scheme should reset KEYMAP_TOGGLE= when KEYMAP is
overriden, and FONT_MAP=, FONT_UNITMAP= if FONT= is overriden.


Lennart

-- 
Lennart Poettering - Red Hat, Inc.