[systemd-devel] [PATCH] docs: fix build without xsltproc

Lennart Poettering lennart at poettering.net
Mon Oct 10 16:17:02 PDT 2011


On Sun, 02.10.11 20:07, Koen Kooi (koen at dominion.thruhere.net) wrote:

> Make would choke on missing rules for man/systemd.1

Hmm, I think this is a misunderstanding:

The original idea here was to require xsltproc when you build from git,
but ship the pre-generated man pages in the tarball so that you don't
need xsltproc when you build from a tarball. configure is a script that
only works properly for the tarball case, and generally is not suitable
for finding dependencies necessary for git builds. (i.e. it won't
install autoconf/automake either, ust assumes they are there.)

Or am I missing something here?

> 
> Signed-off-by: Koen Kooi <koen at dominion.thruhere.net>
> ---
>  Makefile.am |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index f4a17aa..fb48537 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -750,6 +750,7 @@ EXTRA_DIST += \
>          src/dbus-loop.h \
>          src/spawn-agent.h
>  
> +if HAVE_XSLTPROC
>  MANPAGES = \
>  	man/systemd.1 \
>  	man/systemctl.1 \
> @@ -844,6 +845,7 @@ EXTRA_DIST += \
>  	$(XML_IN_FILES) \
>  	${nodist_man_MANS:=.in} \
>  	${XML_IN_FILES:.xml.in=.html.in}
> +endif
>  
>  systemd_SOURCES = \
>  	src/main.c


Lennart

-- 
Lennart Poettering - Red Hat, Inc.


More information about the systemd-devel mailing list