[systemd-devel] [PATCH] docs: fix build without xsltproc

[Koen Kooi]

Op 11 okt. 2011, om 01:59 heeft Lennart Poettering het volgende geschreven:

> On Tue, 11.10.11 01:36, Kay Sievers (kay.sievers at vrfy.org) wrote:
> 
>> 
>> On Tue, Oct 11, 2011 at 01:17, Lennart Poettering
>> <lennart at poettering.net> wrote:
>>> On Sun, 02.10.11 20:07, Koen Kooi (koen at dominion.thruhere.net) wrote:
>>> 
>>>> Make would choke on missing rules for man/systemd.1
>>> 
>>> Hmm, I think this is a misunderstanding:
>>> 
>>> The original idea here was to require xsltproc when you build from git,
>>> but ship the pre-generated man pages in the tarball so that you don't
>>> need xsltproc when you build from a tarball. configure is a script that
>>> only works properly for the tarball case, and generally is not suitable
>>> for finding dependencies necessary for git builds. (i.e. it won't
>>> install autoconf/automake either, ust assumes they are there.)
>>> 
>>> Or am I missing something here?
>> 
>> No, discussed that already on IRC already. I don't think we can do
>> that with current autotools. It would be nice though to support direct
>> builds from git, but I think it needs more than conditionals.
>> 
>> One option here would be to introduce a --disable-docs option.
>> 
>> The other option, obviously, is to fix xsltproc, wait for it to be
>> fixed, to do the right thing, which was the plan last time I talked to
>> Koen. :)
> 
> Fix xsltproc? Hmm? What do you mean? What should it to differently? I
> mean, if it isn't installed it can't do anything differently, can it?

The problem I was trying to fix in systemd was that I don't have the .xsl files in my build sysroot, only on my host. In the past xsltproc happily looked outside the sysroot and things just worked. But a while ago xsltproc was fixed to obey the sysroot and won't find the xsl files on my buildhost anymore. I think we can all agree that that setup needs to get fixed :)

I misunderstood the purpose of the HAVE_XSLTPROC in Makefile.am and sent the patch. Kay explained on IRC that HAVE_XSLTPROC actually means BUILD_FROM_TARBALL, so I'm happy to drop this patch.

regards,

Koen