[systemd-devel] [PATCH] cryptsetup-generator: avoid ordering cycle on swap

[Lennart Poettering]

On Mon, 17.10.11 13:01, Tom Gundersen (teg at jklm.no) wrote:

> Devices with random keys (swap), should not be ordered before local-fs.target,
> as this creates a cycle with systemd-load-random-seed.service (and also it
> does not make sense, a swap device is not a local-fs).

Hmm, your patch makes some sense, but I believe we need to be careful
here: we probably shouldn't try to boot up the machine without swap
activated. Noawadays swap makes little sense unless you have a memory
constrained system, and on those system it's probably quite important to
activate swap before we begin with starting the full memory intensive
snafu.

Could you rework the patch to order the activation of the crypto volumes
before swap.target if they are to be sued for swapping? I think it would
make a lot of sense to have all fs luks before local-fs.target still,
and all swap luks before swap.target. I'll then merge the patch
right-away.

Thanks,

Lennart

--
Lennart Poettering - Red Hat, Inc.