[systemd-devel] [PATCH] Makefile.am: reduce linked libraries

[Koen Kooi]

Op 18 okt. 2011, om 12:51 heeft harald at redhat.com het volgende geschreven:

> From: Harald Hoyer <harald at redhat.com>
> 
> For libselinux and libcap the --as-needed linker flag does not seem to
> work. In fact, it seems to be turned off completly, if one of these
> libraries is used after --as-needed.
> 
> This patch reduces the amount of linked libraries.
> 
> before:
> $ ldd /lib/systemd/systemd-timestamp
> linux-vdso.so.1 (0x00007fffe95ff000)
> libselinux.so.1 => /lib64/libselinux.so.1 (0x000000356d000000)
> libcap.so.2 => /lib64/libcap.so.2 (0x000000356d400000)
> librt.so.1 => /lib64/librt.so.1 (0x000000356cc00000)
> libc.so.6 => /lib64/libc.so.6 (0x000000356b400000)
> /lib64/ld-linux-x86-64.so.2 (0x000000356ac00000)
> libdl.so.2 => /lib64/libdl.so.2 (0x000000356bc00000)
> libattr.so.1 => /lib64/libattr.so.1 (0x000000357b000000)
> libpthread.so.0 => /lib64/libpthread.so.0 (0x000000356c000000)
> 
> after:
> $ ldd systemd-timestamp
> linux-vdso.so.1 (0x00007fff4c333000)
> librt.so.1 => /lib64/librt.so.1 (0x000000356cc00000)
> libc.so.6 => /lib64/libc.so.6 (0x000000356b400000)
> /lib64/ld-linux-x86-64.so.2 (0x000000356ac00000)
> libpthread.so.0 => /lib64/libpthread.so.0 (0x000000356c000000)
> ---
> Makefile.am |   60 ++++++++++++++++++++++++++++++++++++++--------------------
> 1 files changed, 39 insertions(+), 21 deletions(-)
> 
> diff --git a/Makefile.am b/Makefile.am
> index dabe32a..76e5329 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> 
> -	$(CAP_LIBS)
> +        $(CAP_LIBS)

This replaces a tab with spaces and the rest of the patch is using a mixed mode of tab and space as well. What's preferred in the systemd makefiles, tabs or spaces?

regards,

Koen