[systemd-devel] [PATCH 07/14] systemadm: add libgee as dependency and use it for a unit map

[Maciej Marcin Piechotka]

On Mon, 2011-09-19 at 13:24 +0200, Zbigniew Jędrzejewski-Szmek wrote:
> diff --git a/configure.ac b/configure.ac
> index ca07456..5e4b483 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -348,7 +348,13 @@ AM_CONDITIONAL(LIBNOTIFY07, [ test "$libnotify07"
> = "yes" ])
>  
>  AM_PROG_VALAC([0.10])
>  AC_SUBST(VAPIDIR)
> -AM_CONDITIONAL(HAVE_VALAC, test x"$VALAC" != x)
> +AM_CONDITIONAL(HAVE_VALAC, [ test x"$VALAC" != x"" ])
> +
> +PKG_CHECK_MODULES(LIBGEE, [ gee-1.0 ])
> +PKG_CHECK_EXISTS([ gee-1.0 ], [ libgee=yes ])
> +AC_SUBST(LIBGEE_CFLAGS)
> +AC_SUBST(LIBGEE_LIBS)
> +AM_CONDITIONAL(HAVE_LIBGEE, [ test x"$libgee" = x"yes" ])
>  
>  AC_PATH_PROG([XSLTPROC], [xsltproc])
>  AM_CONDITIONAL(HAVE_XSLTPROC, test x"$XSLTPROC" != x) 

I don't think you should:

 - Hard autodetect. Soft autodetection is usually considered fine - such
as in gtk (soft autodetection - --enable-gtk forces build, --disable-gtk
disables it and lack of it dis/enables feature automatically). It may
cause problems for example on Gentoo and may make the life of packagers
in other systems harder.
 - Rename HAVE_GTK to HAVE_LIBGEE

Probably the easiest way is to add the entries to change:

-        PKG_CHECK_MODULES(GTK, [ gtk+-2.0 glib-2.0 > 2.26 gio-unix-2.0
],
+        PKG_CHECK_MODULES(GTK, [ gtk+-2.0 glib-2.0 > 2.26 gio-unix-2.0
libgee-1.0 ],

Regards
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/systemd-devel/attachments/20110919/8883c045/attachment.pgp>