[systemd-devel] [PATCH] unit: fix complementing of requirement deps with After deps for targets

Michal Schmidt mschmidt at redhat.com
Fri Sep 23 04:58:00 PDT 2011


'man systemd.target' says:
  Unless DefaultDependencies= is set to false, target units will
  implicitly complement all configured dependencies of type
  Wants=, Requires=, RequiresOverridable= with dependencies of type
  After=  if the units in question also have DefaultDependencies=true.

It did not work because of a forgotten negation.
---
 src/unit.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/unit.c b/src/unit.c
index 0b435cb..903a8e4 100644
--- a/src/unit.c
+++ b/src/unit.c
@@ -774,7 +774,7 @@ int unit_add_default_target_dependency(Unit *u, Unit *target) {
         /* If either side wants no automatic dependencies, then let's
          * skip this */
         if (!u->meta.default_dependencies ||
-            target->meta.default_dependencies)
+            !target->meta.default_dependencies)
                 return 0;
 
         /* Don't create loops */
-- 
1.7.6.2



More information about the systemd-devel mailing list