[systemd-devel] [systemd-commits] docs/gudev

[Zbigniew Jędrzejewski-Szmek]

On 08/08/2012 06:19 PM, Kay Sievers wrote:
>  docs/gudev/Makefile.am |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> New commits:
> commit 29a00c41b8085596c8d5bba00cc758c38069ab48
> Author: Kay Sievers <kay at vrfy.org>
> Date:   Wed Aug 8 18:16:50 2012 +0200
> 
>     gudev: docs - work around the broken gtk-doc mess
>     
>     gtk-doc add CFLAGS/LDFLAGS multiple times to the gcc command line,
>     which breaks options that must be listed only once.
>     
>     For now, clear CFLAGS/LDFLAGS for the intermediate documentation
>     binary.
> 
> diff --git a/docs/gudev/Makefile.am b/docs/gudev/Makefile.am
> index 586dd8d..152cd3c 100644
> --- a/docs/gudev/Makefile.am
> +++ b/docs/gudev/Makefile.am
> @@ -72,6 +72,14 @@ content_files = version.xml
>  # e.g. expand_content_files=running.sgml
>  expand_content_files=
>  
> +# Hack, hack. You silly gtk-doc, you must not add  CFLAGS multiple
> +# times when calling gcc; it surely can not work with options that must
> +# be listed only once.
> +# Kill CFLAGS here because gtk-doc thinks adding CFLAGS to CC _and_ also
> +# adding CFLAGS itself again would work.
> +CFLAGS=
> +LDFLAGS=
Hi,
are you sure that this works as expected? Quoting info make:
"""
An argument that contains `=' specifies the value of a variable: `V=X'
sets the value of the variable V to X.  If you specify a value in this
way, all ordinary assignments of the same variable in the makefile are
ignored; we say they have been "overridden" by the command line
argument.
"""
So I expect e.g. 'make CFLAGS=...' to cause your override to be ignored.
I think you have to do
  override CFLAGS=
to have certain effect.

Zbyszek