[systemd-devel] [PATCH] systemctl: cleanup dbus code.

[Peeters Simon]

2012/8/7 Peeters Simon <peeters.simon at gmail.com>:
> added a new function: bus_method_call_with_reply which does:
>  dbus_message_new_method_call()
>  dbus_message_append_args()
>  dbus_connection_send_with_reply_and_block()
>  and the needed error handling
> ---
>  src/systemctl/systemctl.c | 1290 ++++++++++++++-------------------------------
>  1 file changed, 400 insertions(+), 890 deletions(-)

hmm, came to the conclusion that this function belongs in dbus-common
so that other parts of systemd can use it to.

The following changes since commit b2c9cbafb8b1a2742978e1faf37fbb3cf4fb5d44:

  units: remove prefdm (2012-08-07 17:08:31 +0200)

are available in the git repository at:

  git://github.com/SimonPe/systemd.git cleanup

for you to fetch changes up to b9c26b413497a0014ac2058a0ec04849a83df1ea:

  logind: use bus_method_call_with_reply() where posible (2012-08-08
17:20:04 +0200)

----------------------------------------------------------------
Simon Peeters (6):
      systemctl: add bus_method_call_with_reply
      systemctl: use bus_method_call_with_reply() where posible
      move bus_method_call_with_reply() to dbus-common
      loginctl: use bus_method_call_with_reply() where posible
      update-utmp: use bus_method_call_with_reply() where posible
      logind: use bus_method_call_with_reply() where posible

 src/login/inhibit.c           |   69 ++--
 src/login/loginctl.c          |  653 +++++++++-----------------------------
 src/login/logind-dbus.c       |   31 +-
 src/login/logind.c            |   47 +--
 src/shared/dbus-common.c      |   73 +++++
 src/shared/dbus-common.h      |   10 +
 src/systemctl/systemctl.c     | 1249
++++++++++++++++++++-----------------------------------------------------
 src/update-utmp/update-utmp.c |  118 +++----
 8 files changed, 650 insertions(+), 1600 deletions(-)