[systemd-devel] [PATCH] use "Out of memory." consistantly (or with "\n")

Kay Sievers kay at vrfy.org
Wed Aug 8 10:22:34 PDT 2012


On Wed, Aug 8, 2012 at 7:09 PM, Lennart Poettering
<lennart at poettering.net> wrote:
> On Wed, 08.08.12 19:06, Kay Sievers (kay at vrfy.org) wrote:
>
>>
>> On Wed, Aug 8, 2012 at 7:02 PM, Lennart Poettering
>> <lennart at poettering.net> wrote:
>> > On Mon, 06.08.12 11:43, shawn (shawnlandden at gmail.com) wrote:
>> >
>> >> -                case '?':
>> >> -                        return -EINVAL;
>> >> -
>> >>                  default:
>> >> -                        log_error("Unknown option code %c", c);
>> >> +                        log_error("Unknown option code '%c'", c);
>> >>                          return -EINVAL;
>> >>                  }
>> >
>> > Hmm, but this would result in one message by getopt() itself and one by
>> > us in case the user uses an unknown switch, no?
>> >
>> > I'd like to turn off that getopt() internal message, but I am not sure
>> > there is a way....
>>
>> leading : in optstring?
>
> Nah, that just changes whether '?' is returned as error char.

Nah, it also suppresses the error.

Kay


More information about the systemd-devel mailing list