[systemd-devel] [PATCH] Fix error message if PR_SET_CHILD_REAPER is not available

shawn shawnlandden at gmail.com
Thu Aug 16 10:38:17 PDT 2012


On Thu, 2012-08-16 at 18:38 +0200, Marius Tolzmann wrote: 
> Hi,
> 
> I just hit some possible wrong error messages. Since prctl() is a 
> system call it won't return -errno but just -1 and set errno to some value.
> 
> The attached patch should fix those error messages, if, for example, PR_SET_CHILD_REAPER is 
> not yet implemented due to an older kernel.

Awesome, I ran into this one too, and thought it was getting errno set
to the wrong value, (EPERM in this case) and was totally confused. It
was just cached.... 
> 
> BTW the REQUIREMENTS section in the README still has Linux kernel >= 2.6.39 in it. May be it 
> should at least be updated to reflect a *recommended* version of Linux kernel >= 3.4?  
> Because the messages I just tried to fix are log_error() and not log_warning().
> 
> Best,
> 
> 	Marius Tolzmann
> 
> 
> Marius Tolzmann (1):
>   main: fix error message if PR_SET_CHILD_REAPER is not available
> 
>  src/core/main.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 


-- 
-Shawn Landden



More information about the systemd-devel mailing list