[systemd-devel] [PATCH 1/3] util: add symlink_atomic()

[Lennart Poettering]

On Sat, 11.08.12 15:22, Shawn Landden (shawnlandden at gmail.com) wrote:

> From: Shawn Landen <shawnlandden at gmail.com>
> 
> unlike symlink_or_copy_atomic(), this function creates a symlink even if the
> oldname and newname (from and to) are on differn't
> devices. (stat.st_dev)

Hmm, I am not sure I get this patch. Removing the "copy" bit from
symlink_or_copy_atomic() also makes the "atomic" bit of it unnecessary,
since creating symlinks is atomic anyway. Hence: why not invoke
symlink() directly?

(Sorry for the late review...)

Lennart

-- 
Lennart Poettering - Red Hat, Inc.