[systemd-devel] eudev fork and patches there

[Tom Gundersen]

On Mon, Dec 17, 2012 at 1:10 PM, Zbigniew Jędrzejewski-Szmek
<zbyszek at in.waw.pl> wrote:
> On Mon, Dec 17, 2012 at 12:34:22PM +0100, Tom Gundersen wrote:
>> On Dec 17, 2012 12:17 PM, "Zbigniew Jędrzejewski-Szmek" <zbyszek at in.waw.pl>
>> wrote:
>> > There's also nice patch bfc850 'Add fallback path when accept4() is
>> > not available.' Do we care about kernels < 2.6.28? (This version is
>> > according to man accept4(2), patch text mentions different versions.)
>>
>> What kernel version is needed depends on the architecture. From memory x86
>> requires .32 and ARM .36.
> According to http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=647825, even
> 3.0 on ia64 was missing the call. So it seems the patch should go in to make
> life easier.

If nothing else, it would make kernel bisection easier. Considering
how minimal the change would be I'd be in favor of adding a fallback
(with a warning).

That said, I don't think we should use the eudev patch as-is. A
run-time fall-back (possibly together with an addition to missing.h)
should be sufficient.

Let's hear what Kay has to say...

Cheers,

Tom