[systemd-devel] [PATCH v3 2/4] service: add watchdog restart/reboot timeouts

[Lennart Poettering]

On Wed, 01.02.12 17:17, Michael Olbrich (m.olbrich at pengutronix.de) wrote:

> This patch adds the WatchdogRestartSec and WatchdogRebootSec
> properties to services. Systemd will restart the service / reboot the
> system if the watchdog timeout has not been updated for the configured
> amount of time.
> This functionality is only enabled if the watchdog timeout is set at
> least once.

Do we really need two timers for this? To me it appears more natural to
introduce one timer, and one option to configure what should happen if
the timeout is reached, simply because we might end up with more than
just two options here (in fact, already I figure we need four...):

WatchdogSec=...
WatchdogAction=restart|reboot|reboot-force|reboot-immediate

Where:

restart = restart the service
reboot = reboot the the machine cleanly, i.e. with shutting down all
         services and unmounting/syncing all disks, via initrd if used
reboot-force = reboot the machine semi-cleanly, i.e. don't shut down
               anything, but still unmount/sync disks and initrd
reboot-immediate = reboot the machine immediately, i.e. don't do
                   anything, but calling the reboot() system call right-away.

Does that make sense? Or can you make a case for having individual
timeouts for these?

Lennart

-- 
Lennart Poettering - Red Hat, Inc.