[systemd-devel] [patch] build: do not touch CFLAGS

Kay Sievers kay.sievers at vrfy.org
Fri Jan 6 17:22:04 PST 2012


On Sat, Jan 7, 2012 at 02:18, Jan Engelhardt <jengelh at medozas.de> wrote:

> Per the automake manual section 3.6 "Variables reserved for the user",
> CFLAGS should _not_ be touched.

That's right.

> Right now, one cannot successfully
> complete `make CFLAGS=-fvisibility=default`, because systemd flags are
> always appended and thus override the user's wish.

That's intentional. We depend on it, and overwriting it breaks stuff.

>  Furthermore,
> it overrides per_target_CFLAGS, which is also undesired.

Guess, we need a cleaner solution, this patch looks even more like a hack.

Kay


More information about the systemd-devel mailing list